Blob tx and instructions - Githubissues

FuelLabs / fuel-vm

Fuel v2 interpreter in Rust

Other

354 stars 86 forks source link

Blob tx and instructions #780

Closed Dentosal closed 2 months ago

Dentosal commented 3 months ago

Work towards https://github.com/FuelLabs/fuel-specs/issues/589. Spec PR: https://github.com/FuelLabs/fuel-specs/pull/592. Core PR https://github.com/FuelLabs/fuel-core/pull/1988.

Open for the first round of reviews, but:

Typescipt support and tests are still missing
Some open questions need to be resolved
- I commented the PR extensively to mark these

Open questions include:

[ ] Should BSIZ charge dependent on size? (same for CSIZ as well)
[ ] Should we implement this for predicates?

Checklist

[x] Breaking changes are clearly marked as such in the PR description and changelog
[x] New behavior is reflected in tests
[x] If performance characteristic of an instruction change, update gas costs as well or make a follow-up PR for that

Before requesting review

[x] I have reviewed the code myself
[x] I have created follow-up issues caused by this PR and linked them here

After merging, notify other teams

[ ] Rust SDK
[ ] Typescript SDK
[ ] Sway compiler
[ ] Platform documentation (for out-of-organization contributors, the person merging the PR will do this)
[ ] Someone else?

xgreenx commented 3 months ago

@Dentosal Could you apply fix from https://github.com/FuelLabs/fuel-vm/pull/789 to your change here as well, please?=)

Dentosal commented 2 months ago

@Dentosal Could you apply fix from #789 to your change here as well, please?=)

Merged master into this, should be applied now.