grow_stack and empty $hp range write fixes - Githubissues

FuelLabs / fuel-vm

Fuel v2 interpreter in Rust

Other

344 stars 77 forks source link

grow_stack and empty $hp range write fixes #788

Closed Dentosal closed 4 days ago

Dentosal commented 4 days ago

Fixes two minor bugs in the memory implementation:

grow_stack was silently truncating the sp to MEM_SIZE even if it was above that
Empty ranges at $hp would fail ownership check, even if they really should pass

Checklist

[x] Breaking changes are clearly marked as such in the PR description and changelog
[x] New behavior is reflected in tests
- The grow_stack case is not tested, as it's not really reachable externally.
[ ] If performance characteristic of an instruction change, update gas costs as well or make a follow-up PR for that
[x] The specification matches the implemented behavior (link update PR if changes are needed)

Before requesting review

[x] I have reviewed the code myself