fix: ensure policies are respected

FuelLabs / fuels-rs

Fuel Network Rust SDK

https://fuellabs.github.io/fuels-rs

Apache License 2.0

44.37k stars 1.33k forks source link

fix: ensure policies are respected #1423

Closed MujkicA closed 3 weeks ago

MujkicA commented 3 weeks ago

Ensures that set gas limit and max fee policies take precedence over estimated values.

Checklist

[ ] I have linked to any relevant issues.
[ ] I have updated the documentation.
[ ] I have added tests that prove my fix is effective or that my feature works.
[ ] I have added necessary labels.
[ ] I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
[ ] I have requested a review from the relevant team or maintainers.

MujkicA commented 3 weeks ago

It seems we made gas limit part of the policies even though that doesn't match the specs.

It is convenient to have these knobs all in one place but it might cause confusion if we differ from the underlying system> It's also a problem when trying to inspect the policies of an executed transaction since we can't easily convert from cores Policy type to our TxPolicies.

We should address this in a future update.