search

FuelLabs / fuels-ts

Fuel Network Typescript SDK
https://docs.fuel.network/docs/fuels-ts/
Apache License 2.0
44.1k stars 1.34k forks source link

Remove ignored faucet link from `.textlintrc.json` #1835

Open nedsalk opened 7 months ago

nedsalk commented 7 months ago

Workflows started failing (e.g. this one) because a captcha was added to https://faucet-beta-5.fuel.network/. We ignored it in #1834 as a temporary fix so that our pipelines can pass, but it's important to not ignore it because we want to be notified by the CI when the link becomes inactive.

The server for the faucet is actually returning a 403 error, which means that it's accessible. If the link checking tool allows it, a solution might be to accept 403 responses as valid.

petertonysmith94 commented 5 months ago

As part of #2218, I added https://forum.fuel.network/ to the ignore list due to flakey responses. I researched the solution outlined above and currently the textlint-rule-no-dead-link does not support this behaviour.

@maschad did recommend an alternative tool markdown-link-check which does appear to be more flexible in configuration.

maschad commented 5 months ago

@nedsalk why can't our CI service be added to an allowlist to by pass the need for captcha?

Worst case scenario as @petertonysmith94 mentioned markdown-link-check supports our custom httpHeaders which we could use for Authorization.