search

FuelLabs / fuels-ts

Fuel Network Typescript SDK
https://docs.fuel.network/docs/fuels-ts/
Apache License 2.0
44.4k stars 1.32k forks source link

ci: dependabot changeset push to use `REPO_TOKEN` #2639

Closed nedsalk closed 4 days ago

nedsalk commented 5 days ago

I believe that this is the same issue that plagued the changeset PR, which was solved in #1848.

maschad commented 5 days ago

Good find, to test this I wonder if we could fork this repo, create a test secret REPO_TOKEN, then modify the dependabot interval to force it to open a PR and then see if the workflow runs there?

nedsalk commented 4 days ago

@maschad I'm fairly certain that this is the root cause because this solution solved the same problem in #1848. IMO we don't need to go out of our way to test it; merging and verifying the behavior live is okay in this case because, even if this PR is a wrong solution, the workflow itself doesn't block anybody from work nor is it of crucial, "we must get this right the first time" importance.

github-actions[bot] commented 4 days ago

Coverage Report:

Lines Branches Functions Statements
80.3%(+0%) 71.8%(+0%) 77.56%(+0%) 80.37%(+0%)
Changed Files: Coverage values did not change👌.