FuelLabs / fuels-ts

Fuel Network Typescript SDK

https://docs.fuel.network/docs/fuels-ts/

Apache License 2.0

44.06k stars 1.34k forks source link

Documentation for `B512` #3241

Open petertonysmith94 opened 1 month ago

petertonysmith94 commented 1 month ago

Summary

Reference

We could rename these to B512 from Bits512 to better align with the wider ecosystem.
We're missing documentation on how to form a B512, from two B256.
I think the example of just using the wallet public key could be changed to show how to form this with two b256.
We could also improve the Sway example with a more complex use-case, rather than just echoing out the response.
The Rust SDK are using the B512::from function (here) and I was unclear how to imitate this with the TS SDK. (this could be a feature request)

jeffersonnnn commented 4 weeks ago

@petertonysmith94 i'd like to handle this. am i okay to go ahead?

petertonysmith94 commented 4 weeks ago

@jeffersonnnn go ahead - we would value your contributions.

Please message here if you have any issues/questions :)

futreall commented 3 weeks ago

Update main.sw #1525 This update includes:

Renaming Bits512 to B512 to better align with the wider ecosystem. Adding documentation on how to form a B512 from two B256. Improving examples to reflect more complex use cases. Thank you for your hard work and collaboration in the community!

Looking forward to your feedback!

arboleya commented 3 weeks ago

@Namanedogawa The PR you mentioned is in another repo — https://github.com/FuelLabs/fuels-rs/pull/1525.

futreall commented 3 weeks ago

Hi @arboleya! Sorry for the confusion. Could you please let me know what’s wrong with my pull request? I’ve opened a new pull request FuelLabs/fuels-rs/pull/1526 and would like to understand what else needs improvement.

petertonysmith94 commented 3 weeks ago

Hi @arboleya! Sorry for the confusion. Could you please let me know what’s wrong with my pull request? I’ve opened a new pull request FuelLabs/fuels-rs/pull/1526 and would like to understand what else needs improvement.

The PR you have created is on the Rust SDK fuels-rs, we are on the Typescript SDK fuels-ts.

futreall commented 3 weeks ago

Update B512Type.ts #3287 check pls