FuelLabs / fuels-wallet

💳 The official Fuel wallet.
https://wallet.fuel.network
Apache License 2.0
917 stars 403 forks source link

Fuel wallet does not have a delete button #1283

Open BlackEyesForThree opened 4 months ago

BlackEyesForThree commented 4 months ago

Motivation

When a user needs to delete one of the sub account addresses, can this feature be added without a convenient delete button? 微信图片_20240510134613

Usage example

No response

Possible implementations

No response

ameeetgaikwad commented 3 months ago

Would like to help!

BlackEyesForThree commented 3 months ago

Thank you very much, so we can start adding the delete button. Used to delete excess addresses from wallet users and add secondary confirmation.

ameeetgaikwad commented 2 months ago

@BlackEyesForThree should i hide it when asked to delete?

Or should i remove the account from the accounts array from useAccounts ?

luizstacio commented 2 months ago

@ameeetgaikwad It depends on the action; Deletion is only possible if the account is imported from a private account. For seed phrases, delete does not exist as accounts are just indexes, and this is why we use the wording hide account.

I think the button should be conditional; if it is from a seed phrase, we show hidden accounts. It it is from privateKey, show delete account.

ameeetgaikwad commented 1 month ago

@ameeetgaikwad It depends on the action; Deletion is only possible if the account is imported from a private account. For seed phrases, delete does not exist as accounts are just indexes, and this is why we use the wording hide account.

I think the button should be conditional; if it is from a seed phrase, we show hidden accounts. It it is from privateKey, show delete account.

got it!