Permanently remove old NFT and Fractional NFT App

FuelLabs / sway-applications

Swaypplications

https://sway-applications.vercel.app/

Apache License 2.0

1.58k stars 540 forks source link

Permanently remove old NFT and Fractional NFT App #748

Closed bitzoic closed 11 months ago

bitzoic commented 11 months ago

Type of change

Improvement (refactoring, restructuring repository, cleaning tech debt, ...)

Changes

The following changes have been made:

With the https://github.com/FuelLabs/sway-applications/pull/747 pull request, the NFT and Fractional NFT apps may be deleted to avoid confusion and prevent developers from using this as a reference.

Notes

Nothing about this app should be used.

bitzoic commented 11 months ago

Is the new NFT PR supporting the functionality of the F-NFT now that we have sub_id's? The F-NFT with its shares was cool and should be removed after a replacement for it exists.

Check the .devops to see if these need to be removed from there too.

The F-NFT will ONLY work with the outdated and bad practice NFT project and a non-existent library.

There will be a new standard soon^tm where this can be implemented.

Braqzen commented 11 months ago

Is the new NFT PR supporting the functionality of the F-NFT now that we have sub_id's? The F-NFT with its shares was cool and should be removed after a replacement for it exists. Check the .devops to see if these need to be removed from there too.

The F-NFT will ONLY work with the outdated and bad practice NFT project and a non-existent library.

There will be a new standard soon^tm where this can be implemented.

Okay, this needs updating then can approve