search

FuelLabs / sway-applications

Swaypplications
https://sway-applications.vercel.app/
Apache License 2.0
1.57k stars 537 forks source link

Delete AMM App #768

Closed SwayStar123 closed 6 months ago

SwayStar123 commented 6 months ago

The original author of the AMM app has left the fuel organization, this plus the fact that the sway code has very little comments, and that the tests are written in an abstract way, makes this app very hard to maintain.

Type of change

Changes

The following changes have been made:

Braqzen commented 6 months ago

"I find it difficult to maintain this" is not a valid reason to delete this.

SwayStar123 commented 6 months ago

@hummusonrails

K1-R1 commented 6 months ago

If bumping the AMM has become a significant blocker, rather than delete I'd advocate that we archive the AMM temporarily as we did the Fraction-NFT (#714). However the intention would then be to reintroduce the AMM at a later date. Perhaps with a refactor/rebuild if it has become too difficult to maintain in it's current form. The AMM app is a great example app, especially for the usage of scripts, and I don't think we should delete it.

SwayStar123 commented 6 months ago

Closed in favour of #769