search

FuelLabs / sway

🌴 Empowering everyone to build reliable and efficient smart contracts.
https://docs.fuel.network/docs/sway/
Apache License 2.0
62.59k stars 5.37k forks source link

Rename `ec_recover` to `ec_recover_k1` #5219

Open Braqzen opened 1 year ago

Braqzen commented 1 year ago

With the introduction of #5133 we have some new recovery functionality.

There are 2 related opcodes, erc1 & eck1. For consistency we should rename ec_recover to be explicit similar to the new r1 function.

Braqzen commented 1 year ago

Thoughts cc @bitzoic ? I'm happy to make the changes.

bitzoic commented 1 year ago

No, erc1 is the default and is used in the Fuel ecosystem. erk1 should only be used under special circumstances, this was left as is intentionally.

Braqzen commented 1 year ago

No, erc1 is the default and is used in the Fuel ecosystem. erk1 should only be used under special circumstances, this was left as is intentionally.

This has nothing to do with defaults. It's about distinguishing between the recovery