FuelLabs / sway

๐ŸŒด Empowering everyone to build reliable and efficient smart contracts.
https://docs.fuel.network/docs/sway/
Apache License 2.0
62.76k stars 5.36k forks source link

Update all Cargo.toml files to use workspace dependency versions #6501

Closed alfiedotwtf closed 1 week ago

alfiedotwtf commented 3 weeks ago

Description

This PR relates to #6179 which aims to simplify individual workspace member dependency versioning by deferring upstream to the workspace dependencies itself.

I've also extended #6179 as it currently only relates to external dependencies - I've noticed that whenever Sway has a version bump, the diffs manually update all of the many Cargo.toml files to the new globally shared version. We can also use workspaces here to defer each Cargo.toml package version to the workspace package version as well.

This PR is in 3 parts:

  1. Update all Cargo.toml external dependencies to use the shared versions defined in the workspace dependencies
  2. Update all Cargo.toml package version to defer to the workspace package version.
  3. Update all external dependencies to their latest versions

If an individual workspace member needs to break away from the shared workspace package version, we can still do that:

Notes:

Checklist

codspeed-hq[bot] commented 3 weeks ago

CodSpeed Performance Report

Merging #6501 will degrade performances by 17.31%

Comparing alfie/6179-cargo-workspace-version (4957517) with master (a073a95)

Summary

โšก 1 improvements โŒ 1 regressions โœ… 20 untouched benchmarks

:warning: Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark master alfie/6179-cargo-workspace-version Change
โšก code_lens 6.1 ยตs 5.5 ยตs +11.09%
โŒ document_symbol 4.3 ms 5.2 ms -17.31%
Voxelot commented 3 weeks ago

nice ๐Ÿ˜Ž Screenshot from 2024-09-06 11-01-55

sdankel commented 3 weeks ago

Closes https://github.com/FuelLabs/sway/issues/5845

JoshuaBatty commented 3 weeks ago

Awesome to see this. so much cleaner.

alfiedotwtf commented 2 weeks ago

Just forced-pushed to remove a comment that I accidentally left in while testing

Edit: And added more documentation to narrow down to a single GitHub Actions job