Fixed required trait constraint not being checked

esdrubal commented 2 weeks ago

Description

An optimization on check_if_trait_constraints_are_satisfied_for_type_inner was making missing trait constraints not being detected.

Fixes #6374.

[x] I have linked to any relevant issues.
[x] I have commented my code, particularly in hard-to-understand areas.
[ ] I have updated the documentation where relevant (API docs, the reference, and the Sway book).
- [ ] If my change requires substantial documentation changes, I have requested support from the DevRel team
[x] I have added tests that prove my fix is effective or that my feature works.
[x] I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
[x] I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
[x] I have requested a review from the relevant team or maintainers.

codspeed-hq[bot] commented 2 weeks ago

_{Comparing esdrubal/fix_additional_constraints (44a5d0d) with master (15c8298)}

✅ 22 untouched benchmarks

sdankel commented 1 week ago

Should we add a test of the repro from the original issue?

esdrubal commented 1 week ago

Should we add a test of the repro from the original issue?

Thanks for noticing, I added the missing test.