Fixes OOB in type_check_analyze of ImplTrait.

FuelLabs / sway

🌴 Empowering everyone to build reliable and efficient smart contracts.

https://docs.fuel.network/docs/sway/

Apache License 2.0

62.58k stars 5.37k forks source link

Closed esdrubal closed 2 months ago

esdrubal commented 2 months ago

An unused line of code threw an OOB panic because of a parser error. Removing the unused line of code fixes the issue.

Fixes #6331

[x] I have linked to any relevant issues.
[x] I have commented my code, particularly in hard-to-understand areas.
[ ] I have updated the documentation where relevant (API docs, the reference, and the Sway book).
- [ ] If my change requires substantial documentation changes, I have requested support from the DevRel team
[x] I have added tests that prove my fix is effective or that my feature works.
[x] I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
[x] I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
[x] I have requested a review from the relevant team or maintainers.

codspeed-hq[bot] commented 2 months ago

_{Comparing esdrubal/oob (22e2e5c) with master (db74865)}

❌ 1 regressions ✅ 21 untouched benchmarks

:warning: Please fix the performance issues or acknowledge them on CodSpeed.

	Benchmark	`master`	`esdrubal/oob`	Change
❌	`document_symbol`	4.3 ms	4.8 ms	-10.18%