Closed JoshuaBatty closed 1 month ago
Comparing josh/panic_on_save
(8cc5062) with master
(28c8ae4)
❌ 1
regressions
✅ 21
untouched benchmarks
:warning: _Please fix the performance issues or acknowledge them on CodSpeed._
Benchmark | master |
josh/panic_on_save |
Change | |
---|---|---|---|---|
❌ | document_symbol |
4.4 ms | 5.4 ms | -18.06% |
Description
I noticed that the language server would crash when compilation was triggered from a did save event as we were trying to create runnables from the Engines that had GC applied to it. We now check to ensure that the correct Engines is accessed to avoid a panic when creating runnables.
After fixing this bug, I noticed that optimised builds was not returning diagnostics. I've opened #6576 to work on this and have temporarily disabled the optimisation so diagnostics continue to work.
Checklist
Breaking*
orNew Feature
labels where relevant.