search

FuelRats / pipsqueak

ED Fuel rats IRC bot
Other
13 stars 14 forks source link

Refuse to close cases with 'unknown' as the platform. Resolves MECHA-219 #205

Closed tivec closed 7 years ago

Marenthyu commented 7 years ago

Did you test this change? I'm not 100% sure what the default value for platform is, it might be None or "unknown" - if it's the latter, this should work as expected. Will check and merge later.

tivec commented 7 years ago

Tested on my personal pipsqueak instance in #tivecdev:

[09:14:11] <tivsqueak> Received R@SIGNAL from Tivec.  Calling all available rats!  (Case 0)
[09:14:12] <tivsqueak> Tivec: Are you on emergency oxygen? (Blue timer on the right of the front view)
[09:14:12] <@Tivec> !close 0
[09:14:14] <tivsqueak> The case platform is unknown. Please set it with the corresponding command and try again.
[09:14:23] <tivsqueak> Tivec's platform set to PC
[09:14:25] <@Tivec> !close 0
[09:14:25] <tivsqueak> Case Tivec got cleared!

I will append a test for platform not being assigned too, patch incoming.

Marenthyu commented 7 years ago

Looks good!