FuelRats / pipsqueak

ED Fuel rats IRC bot
Other
13 stars 14 forks source link

Adding platform specific !quiet commands and rate limiting #243

Closed Holladiewal closed 6 years ago

Holladiewal commented 6 years ago

I know these are two changes at once, I deeply apologize for this

I never intended to do the reformatting, please don't take my snickers for that

  1. there are now platform-specific !quiet commands (!quiet-pc, !quiet-ps, !quiet-xb) and a global !quiet (works like the old)
    1. These do respect platform changes and have dealt with no problem so far in my testing
    2. they do not trigger on !inject (this was definitely how it worked before) nor on custom signals (that might be also from before)
  2. !quiet is now rate limited
    1. every user can trigger it once per 10 minutes
    2. it can be triggered once every minute per channel
    3. Rate limiting does not apply in PMs nor does it count towards your limit
kenneaal commented 6 years ago

Last I checked, we were not going to implement platform specific !quiets. A lot of the reasoning behind that is because !quiet is already being overused, and giving the mischief platform specific versions is just going to generate /more/ frivolous usage of the command.

Holladiewal commented 6 years ago

There was some discussion on how to make it more "acceptable" over in #popcorn.
From what I recall (or my ideas):

I'm not against changing the output and it surely can be done in less time than implementing the logic for this.

UncleClapton commented 6 years ago

After some discussion about this PR, the janitorial staff have decided to reject this PR under concerns for overall generated spam. This doesn't mean we want to stop any expansion of !quiet as a command, however. We are currently waiting on more input on how we would like to see platform specific timers implemented, but expect us to get in touch as soon as we do.

Holladiewal commented 6 years ago

Ok, I'll put that project in several safe locations as it is and reset my branches for the time being.