FuelRats / pipsqueak

ED Fuel rats IRC bot
Other
13 stars 14 forks source link

MECHA-253: Implement !reopen without refreshing all cases #260

Open MHajoha opened 6 years ago

MHajoha commented 6 years ago

Been toying around with giving only the reopened case a new index rather than remaking the whole board from the API, but I have no way of testing my code. See MECHA-253

theunkn0wn1 commented 6 years ago

I have started on the Mecha 3 project, though it's a long way from fruition. I'm currently experimenting with the pydle framework but I have not done enough to warrant making a commit to this repo (quick and dirty hacks need to get cleaned up first).

Once I have more of the Mecha 3 core down I'll commit so others can contribute.

That said, my focus is on maintaining Mecha 2 and expanding it's features as such requests/needs arise. Mecha 2 is to remain supported until Mecha 3 is ready too replace it seamlessly

On Jan 31, 2018 16:41, "Maximilian Haye" notifications@github.com wrote:

@MHajoha commented on this pull request.

In sopel_modules/rat_board.py https://github.com/FuelRats/pipsqueak/pull/260#discussion_r165231452:

@@ -1648,9 +1648,19 @@ def cmd_reopen(bot, trigger, id): """ try: result = callapi(bot, 'PUT', data={'status': 'open'}, uri='/rescues/' + str(id), triggernick=str(trigger.nick))

  • refresh_cases(bot, force=True)
  • updateBoardIndexes(bot)
  • bot.say('Reopened case. Cases refreshed, care for your case numbers!')
  • try:
  • addNamesFromV2Response(result['included'])
  • except:
  • pass

Also, is Mecha3 already on its way to becoming a thing? As in a complete rewrite against pydle or similar?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/FuelRats/pipsqueak/pull/260#discussion_r165231452, or mute the thread https://github.com/notifications/unsubscribe-auth/AC94SkCZ2aCJEFg1hBR97AN3v7iPsv9iks5tQQglgaJpZM4RvWLR .

MHajoha commented 6 years ago

Sounds great. I've been writing around at such a thing myself, though more out of personal interest than anything else. Perhaps you could make what you've done so far a repo of it's own for now, because I'd love to contribute.