search

FuelRats / pipsqueak

ED Fuel rats IRC bot
Other
13 stars 14 forks source link

Feature/mecha 192 #262

Closed theunkn0wn1 closed 6 years ago

theunkn0wn1 commented 6 years ago

This PR does two things: Firstly it makes a change to the Rescue object.

Due to API v2.1 requirements, all system names must be transmitted in upper case, but mecha as it stands on the develop branch does not cast system names to upper case therefore can cause 422 errors.

The first change is the Rescue.System() field now uses a SystemNameProperty object to store the system name in memory. This class simply casts the input string to uppercase, ensuring Mecha complies with API v2.1 requirements.

Second change: The RATSIGNAL phrase has been added to: it will now include platform-specific strings at the end of the message. The added phrases are

These will allow rats to set platform-specific pings while preserving the ratsignal.

theunkn0wn1 commented 6 years ago

If anyone has any feedback before i merge this, please leave it within the next 48 hours.

Marenthyu commented 6 years ago

I suppose these 48 hours have passed