search

FuelRats / pipsqueak

ED Fuel rats IRC bot
Other
13 stars 14 forks source link

Everything in !list red after (CR) #77

Closed Ozei closed 8 years ago

Ozei commented 8 years ago

ratsqueakcrbug

As you can see, everything after (CR) is in red in !list response.

Not the biggest or most urgent issue, but thought I would report it.

blackrabt commented 8 years ago

Could this be fixed at line 265 in rat-board.py by changing bot.reply('{0}\'s case ({1}):'.format(cmdr, plat)) to bot.reply('{0}\'s case ({1}):'.format(cmdr, plat(color(colors.BLACK))))

That way it will always assign black text unless it is told otherwise, when sending the list to chat.

I haven't had a chance to test it out yet but it seems like it would work. - Second thought, I think it needs to be put at the head of that line.

tyrope commented 8 years ago

better fix would be to suffix the undo to the end of the CR tag, where the CR tag is created.

Tho I'm not sure what the sopel way of doing that off the top of my head, specific code I'm referring to is https://github.com/FuelRats/pipsqueak/blob/sopel-master/sopel-modules/rat-board.py#L330

blackrabt commented 8 years ago

Indeed. Good thinking sir.

Guess it will be a bit of testing to see what does the job.

blackrabt commented 8 years ago

We tried to replicate the issue and could not. What IRC client and version are you using Ozei?

Issue is replicatable in irssi but not all IRC clients.

Ozei commented 8 years ago

I am using Irssi v. 0.8.15

I do realize that Irssi is wonky with colours, and that this issue is cosmetic and affects like 5 people...