Fueled / django-init

Project template used at Fueled for scaffolding new Django based projects. :dizzy:
Other
189 stars 46 forks source link

feat: Use poetry everywhere #463

Open theskumar opened 1 year ago

theskumar commented 1 year ago

Why was this change necessary?

This project gereates requirements.txt for legacy reasons which didn't require poetry to be installed on the CI, heroku or other places.

Installing poetry is cheap and infact used in the docker and github actions already. This PR installs poetry during setup with ansible and heroku as well. Eliminating the need for keeping requirements.txt in the source control. poetry.lock is used instead for installation via poetry cli.

How does it address the problem?

Are there any side effects?

Poetry becomes a hard dependency for installing and managing python dependencies everywhere.

closes: https://github.com/Fueled/django-init/issues/476

CuriousLearner commented 1 year ago

The changes looks good to me. However, I was thinking to keep vagrant (and possibly update it with the latest Ubuntu version on AWS). My rationale on keeping it is that it helps in testing ansible deployments and any changes that are done there. Otherwise, they'll have to be tested on a dev/qa server.

Please let me know what you think.

theskumar commented 1 year ago

I was more worried about its maintainability of it. But a agree that it's useful. If it can be updated to match with the supported version it will be worth not removing it.

CuriousLearner commented 1 year ago

465

theskumar commented 11 months ago

Updated code so it doesn't touch on vagrant or VM setup

skhaz commented 11 months ago

Looks good to me.