search

FugiTech / google-meet-grid-view

Userscript to offer a grid-view layout in Google Meets
https://greasyfork.org/en/scripts/397862-google-meet-grid-view
Other
623 stars 272 forks source link

Grid view isn't working. #263

Open Daxter027 opened 4 years ago

Daxter027 commented 4 years ago

It was working properly for a month but in the last two days, it started glitching. It used to show all the participants in the meet but now it shows only my video pinned.

Daxter027 commented 4 years ago

image

ghost commented 4 years ago

same problem here

joseholanda commented 4 years ago

Anyone know why this is happening?

sananthraj commented 4 years ago

same issue. till now

ma2shita commented 4 years ago

The output of the console was as follows.

grid.user.js:1032 TypeError: v[magicKey].isPinned is not a function
    at grid.user.js:1361
    at Array.findIndex (<anonymous>)
    at _.rU.GridLayout (grid.user.js:1361)
    at Object.Aa (grid.user.js:1030)
    at m=E2pBMd,FLsD7e,G2zYh,MJfjyf,Rj6Bdc,Zh9EBd,ddSxB,fMo1Id,igdIHf:143
    at nab (m=A7fCU,AJ9SK,(snip):733)
    at _.Ew._.h.Ym (m=A7fCU,AJ9SK,(snip):732)
    at forceReflow (grid.user.js:1115)
    at updateSetting (grid.user.js:1601)
    at HTMLDivElement.toggleButton.onclick (grid.user.js:817)

It seems to be due to not found isPinned(). https://github.com/Fugiman/google-meet-grid-view/blob/eea5772d4436fcd1507bd56ba47f8405a61b5c04/grid.user.js#L1361

I made a temporary change then it worked. (Suppose the pinned element does not exist.)

< let pinnedIndex = ret.findIndex(v => v[magicKey].isPinned())
> let pinnedIndex = -1
icysapphire commented 4 years ago

@sananthraj @joseholanda @Heman-t04 https://chrome.google.com/webstore/detail/google-meet-grid-view-fix/dakebdbeofhmlnmjlmhjdmmjmfohiicn This is just a temporary workaround (which looses the pinning feature) [credits: @ma2shita], in order to allow people who heavily rely on the extension (e.g., online exams) to continue their work. The extension will be removed as soon as Chris is able to properly fix the issue. Just temporary disable the problematic extension and activate this one.

Daxter027 commented 4 years ago

Does it work properly?? Please reply as I have exams next week

ghost commented 4 years ago

ya this fix works same as the original function just lacking in pinning feature

ghost commented 4 years ago

@icysapphire till when the original grid view will start working

Daxter027 commented 4 years ago

I used it and it worked perfectly fine......thank you!!

Daxter027 commented 4 years ago

Hey!!! The temporary extension also is not working now...... When I turn on the grid view I can see everyone in a list only... is the original one working again? Is that why this one is not working?? Pls help

ghost commented 4 years ago

ya it has stopped working