search

Fuglesteg / lem-guix-packaging

Packaging effort for making Lem available for Guix
1 stars 2 forks source link

Lem is in Guix #2

Open jgarte opened 2 months ago

jgarte commented 2 months ago

Hi,

Lem is in Guix now 🎉

https://git.savannah.gnu.org/cgit/guix.git/commit/?id=e92516d900927bf8efceecc161c78f03785ded71

I added you as co-author on all the packages that I used as starting points from this repository.

Thanks!

Fuglesteg commented 2 months ago

Hey!

Thanks for taking care of this, awesome job! 🎉 Seems as if you haven't actually added me as a co-author. Only my co-author, Ada (@arthur-dog) hehe. Anyways it's no big deal, I appreciate the work you have done!

I have some questions about how you managed to simplify the package definition so much, if you don't mind answering ;) Mainly I'm wondering how you were able to get everything working without the extra build stages like override-ql, redirect-home and set-default-implementation. Particularly how micros is working without the set-default-implementation stage. Has there been changes in Lem to address this? Very impressed with how simple the definition ended up being :)

jgarte commented 1 month ago

Hi,

redirect-home and set-default-implementation. Particularly how micros is working without the set-default-implementation stage. Has there been changes in Lem to address this?

I have not run into any issues with this. Can you explain the need for the extra phases and why they were needed?

There have been updates to lem and micros since.

Could you try the latest lem package in Guix and let me know if there are any issues on your end with the latest package in the Guix master branch?

I'd be happy to review any patches from you. I have commit access to GNU Guix.

jgarte commented 1 month ago

@Fuglesteg Here's one issue I am running into with the current lem package:

https://github.com/lem-project/lem/discussions/1567

If you have any thoughts on it, feel free to contribute to the QA discussion. Any help is much appreciated.

The lem package from lem-guix-packaging did not build terminal.c but used the pre-compiled shared object files for terminal.c.

Fuglesteg commented 1 month ago

Hi,

redirect-home and set-default-implementation. Particularly how micros is working without the set-default-implementation stage. Has there been changes in Lem to address this?

I have not run into any issues with this. Can you explain the need for the extra phases and why they were needed?

There have been updates to lem and micros since.

Could you try the latest lem package in Guix and let me know if there are any issues on your end with the latest package in the Guix master branch?

I'd be happy to review any patches from you. I have commit access to GNU Guix.

I have tried the Lem package and it works great. I haven't ran into any issues. I was just curious if you were aware of why the stages were no longer required. I guess there have just been a bunch of changes in Lem. All the build phases were required to get Lem to build when I was working on it. The set-default-implementation stage was required to fix the slime command, Lem would try to use roswell to start a cl implementation so we would override the default implementation to use SBCL instead.