search

FugroRoames / Munkres.jl

Munkres algorithm for the optimal assignment problem
Other
20 stars 7 forks source link

Update for julia 0.7 #11

Closed kdw503 closed 5 years ago

kdw503 commented 5 years ago

This resolved all the deprecation warnings under julia 0.7.

timholy commented 5 years ago

See also #10. This package is suddenly all the rage!

PaulBellette commented 5 years ago

Hey thanks for that! You make me feel lazy, I've had no time to look at this package in eons. @andyferris or @JoshChristie have all the power over this repo these days...

c42f commented 5 years ago

@JoshChristie or @andyferris you could probably add @PaulBellette back as a collaborator just for this repo.

Looking through both this and #10 they are almost identical but I'd merge this in preference due to a few additional niceties (adding 1.0 support in CI, an updated appveyor config, fwiw, and on the whole slightly more idiomatic julia code rewrite).

andyferris commented 5 years ago

@JoshChristie or @andyferris you could probably add @PaulBellette back as a collaborator just for this repo.

Done. I didn't realize you that "external collaborator" to the organization didn't give access to the repos.

c42f commented 5 years ago

Oh, I didn't realise we were classed as external collaborators still. There are per-collaborator permissions perhaps those were just set oddly.

kdw503 commented 5 years ago

Thank you all for reviewing and merging this commit. Is it possible to tag a new version number for this merging?

andyferris commented 5 years ago

https://github.com/JuliaLang/METADATA.jl/pull/18752