Closed JoshChristie closed 8 years ago
Looks good, only one thought here - if we want to add extra constructors later, having the convenience constructor SparseVoxelGrid(points, 1.0, 2.0, 10.0)
will make the extra arguments harder to distinguish.
I'd perhaps be inclined to remove the convenience constructor, and replace it with one taking a tuple SparseVoxelGrid(points, (1.0, 2.0, 10.0))
Then the second argument is the voxel size rather than it being possibly the second, or possibly the second, third, fourth arguments.
So yes, in some ways I prefer the version taking the Vec!
Okay, good idea. I will change it to a tuple. Thanks!
Can now do this:
Or if you really wanted to (not likely?):