Fujicracy / fuji-v2

Cross-chain money market aggregator
https://fuji-v2-frontend.vercel.app
15 stars 10 forks source link

Support and Tests for Rebalancer Manager #133

Closed pedrovalido closed 1 year ago

pedrovalido commented 1 year ago

Implemented more tests and some malicious use cases for Rebalancer Manager. Not sure how to test some of errors of Rebalancer Manager but am working on them. Btw, let me know what you think of what has been implemented. Keep in mind the commit has some spam because it is a WIP and will be clean when is ready for review.

@DaigaroCota @brozorec

0xdcota commented 1 year ago

Hey @pedrovalido , everything looks good to me so far. Only noticed one test was not working. I left a comment for that.

I also saw intention to test the remaining of the errors, it will be great if those can be tested too.

Also just wanted to point out good job on making the applicable tests, fuzz tests.

pedrovalido commented 1 year ago

I've implemented the rest of test for errors that were missing along with some notes in the form of comments. Let me know what else I can test/improve/discuss

0xdcota commented 1 year ago

@pedrovalido feel free to merge.