Borrow: add providers dropdown

Fujicracy / fuji-v2

Cross-chain money market aggregator

https://fuji-v2-frontend.vercel.app

15 stars 10 forks source link

Borrow: add providers dropdown #147

Closed doliG closed 1 year ago

doliG commented 1 year ago

close #137

github-actions[bot] commented 1 year ago

Please test this PR on: https://v2-staging-147-dot-fuji-306908.ey.r.appspot.com

doliG commented 1 year ago

Hello @brozorec , can you review this ?

Also, I've added some fix on thie PR:

fix: Warning getServerSnapshot should be cached to avoid infinit loop
fix: mumbai icon
fix: collateral will be deposited into icon
fix: hovering user address
fix: goerli key for infura

Thanks 🙏

brozorec commented 1 year ago

hey @doliG

Question: Is the dropdown functional already? When I select Mumbai for src and dest chain, I'm pretty sure there's only one vault so normally there should be nothing to select there, but I'm still having the dropdown list.
The app crashes when I select goerli for src and/or dest and click on the dropdown.

fix: collateral will be deposited into icon

I don't see any icon, maybe because you don't have one for "Mock V0", so I suggest you put a default one

fix: hovering user address

I don't see any change from yesterday but I suggest you leave this out and move forward with the stuff that is more important

doliG commented 1 year ago

Question: Is the dropdown functional already? When I select Mumbai for src and dest chain, I'm pretty sure there's only one vault so normally there should be nothing to select there, but I'm still having the dropdown list.

Yes because the list display all the vault including the one selected.

The app crashes when I select goerli for src and/or dest and click on the dropdown.

Can reproduce, will fix

I don't see any icon, maybe because you don't have one for "Mock V0", so I suggest you put a default one

This is the expected one, there shouldn't be any case where we have no Icon in the assets. Also, I think about it but I have no idea what can represent a provider for a default icon...

I don't see any change from yesterday but I suggest you leave this out and move forward with the stuff that is more important

Refresh without cache, also test with firefox. It works on my machine.

brozorec commented 1 year ago

Yes because the list display all the vault including the one selected.

Then I'd suggest that we don't have in the list the one that's selected.

This is the expected one, there shouldn't be any case where we have no Icon in the assets. Also, I think about it but I have no idea what can represent a provider for a default icon...

We can use Aave as default.

doliG commented 1 year ago

Then I'd suggest that we don't have in the list the one that's selected.

I disagree, this behavior is the same on all other menu, and I don't want to start making exception. If there is only one vault available, I think it's better to disable the dropdown like this:

I went ahead and implemented it.

When I select Mumbai for src and dest chain, I'm pretty sure there's only one vault so normally there should be nothing to select there, but I'm still having the dropdown list.

Actually, await sdk.getBorrowingVaultsFor(collateral, debt) with collateral AND debt on Mumbai returns 2 vaults, one on optimism goerli and one on mumbai. There may be a bug here. To check / reproduce put a console.debug in async updateVault() {.

We can use Aave as default.

Done