search

Fujicracy / fuji-v2

Cross-chain money market aggregator
https://fuji-v2-frontend.vercel.app
15 stars 10 forks source link

Deploy Factory #170

Closed brozorec closed 1 year ago

brozorec commented 1 year ago

close #153

brozorec commented 1 year ago

@DaigaroCota none of the forking tests pass on my end, do they on yours? forge test --mp 'test/forking/**/*.sol'

0xdcota commented 1 year ago

@DaigaroCota none of the forking tests pass on my end, do they on yours? forge test --mp 'test/forking/**/*.sol'

All of the forking tests failing in this branch protocol/refactor/factory on my side too.

@brozorec I saw the error and it spits Chief__onlyTimelock_callerIsNotTimelock(). I am fixing this on branch protocol/fix/cs-withdraw-all-assets-shares-error.

Though the only error I can't figure out is this: [FAIL. Reason: Could not instantiate forked environment with fork url: https://rpc-mumbai.maticvigil.com]

0xdcota commented 1 year ago

FYI. I solved the [FAIL. Reason: Could not instantiate forked environment with fork url: https://rpc-mumbai.maticvigil.com] by switching to a different RPC. In my case I used: https://rpc.ankr.com/polygon_mumbai.

brozorec commented 1 year ago

These errors appeared after I updated from "main" where these tests fail too.

Based on the above, this PR should be merged after #180