search

Fujicracy / fuji-v2

Cross-chain money market aggregator
https://fuji-v2-frontend.vercel.app
15 stars 10 forks source link

Onboard modal theming #193

Closed doliG closed 1 year ago

github-actions[bot] commented 1 year ago

Please test this PR on: https://v2-staging-193-dot-fuji-306908.ey.r.appspot.com

doliG commented 1 year ago

Hey @Markoyw can you please check this PR (see the link above) and tell me if the theming looks good ?

I can't change the display & behavior, but I can change all the colors.

Markoyw commented 1 year ago

Hi @doliG

Here are some feedbacks on the modal theming: https://www.figma.com/file/v53wiSwcL5DYynVL0z6L4s/Fuji---Working-File-(NEW)?node-id=3076%3A52424&t=dKvFigC3uMvukkmZ-1

doliG commented 1 year ago

Hey @Markoyw , I think there's a confusion: by modal theming I mean login modal when you click on "connect" button:

image

But your feedbacks are 100% valid, so I included them in this PR. It's live so you can test 🤓

Background colour: #3C3D41

This color is not part of the design system. Should we include it or is it just a one time use ?

Markoyw commented 1 year ago

Hey @doliG, are we able to change the font used on the modal pop-up?

If yes, I'd recommend that we keep it consistent to 'Inter'

doliG commented 1 year ago

@Markoyw yes, I just did it in c0c6f414564ae913d4b622190f98286130e15485