Fujicracy / fuji-v2

Cross-chain money market aggregator
https://fuji-v2-frontend.vercel.app
15 stars 10 forks source link

Vaults lack of slippage protection #210

Closed 0xdcota closed 1 year ago

0xdcota commented 1 year ago

This PR deals only with slippage protection on a vault level. Should we extend it to the Router too (maybe in another PR)?

I recommend that we deal with router-swap slippage separately in a new Issue-ticket because is a complete different approach. I even think the slippage in the router should be implemented in the Swapper-types contract.