search

Fujicracy / fuji-v2

Cross-chain money market aggregator
https://fuji-v2-frontend.vercel.app
15 stars 10 forks source link

Add version in Vaults and setter for ratings in Chief #224

Closed 0xdcota closed 1 year ago

0xdcota commented 1 year ago

Discussed in Smart Contracts meeting Jan 5, 2023

We decided to add a public state variable in the BaseVault contract that returns a version. This version will be used to identify the revision of future deployments of vaults.

In addition, we agreed on creating a setter function for the vault ratings in the Chief contract.

0xdcota commented 1 year ago

@brozorec I am thinking version to be a constant string with format v0.0.0? 

/**
   * @dev `VERSION` of this vault. 
   * Software versioning rules are followed: v-0.0.0
   *  MAJOR version when you make incompatible ABI changes
   *  MINOR version when you add functionality in a backwards compatible manner.
   *  PATCH version when you make backwards compatible fixes.
   */
  string public constant VERSION = "v-0.0.0";

what do you think?