Fixes and calls optimization - Githubissues

Fujicracy / fuji-v2

Cross-chain money market aggregator

https://fuji-v2-frontend.vercel.app

15 stars 10 forks source link

Fixes and calls optimization #282

Closed brozorec closed 1 year ago

brozorec commented 1 year ago

https://github.com/Fujicracy/fuji-v2/blob/8473be70aba6da193d4d1ff1cc87d280250fd1b1/packages/frontend/store/transaction.slice.ts#L241

[x] No need for this. vault.getProviders() calls internally preLoad if needed.

https://github.com/Fujicracy/fuji-v2/blob/8473be70aba6da193d4d1ff1cc87d280250fd1b1/packages/frontend/store/transaction.slice.ts#L256

[x] This is should be fixed. Not always, activeProvider is the first in the list. LendingProviderDetails returned by vault.getProviders() contains a field active. Here we need to set according that field.

https://github.com/Fujicracy/fuji-v2/blob/7b3407f8b415976105cdb1b60348aaa069fdd0d2/packages/frontend/components/Borrow/Overview.tsx#L259

[x] Multiply by 100 to get the result as % and round to 2 after the decimals. It should display 1.23%

https://github.com/Fujicracy/fuji-v2/blob/7b3407f8b415976105cdb1b60348aaa069fdd0d2/packages/frontend/store/transaction.slice.ts#L331

[x] Remove this condition. Already can fetch proper values.