search

Fujicracy / fuji-v2

Cross-chain money market aggregator
https://fuji-v2-frontend.vercel.app
15 stars 10 forks source link

Update frontend assets #284

Closed ferostabio closed 1 year ago

ferostabio commented 1 year ago

From issue https://github.com/Fujicracy/fuji-v2/issues/283

ferostabio commented 1 year ago

@brozorec quick question:

We have a list of network assets. They're

Arbitrum
Binance
Ethereum
Fantom
Optimism
Polygon
Potcoin

Which ones can we remove for v1?

Also, we're currently duplicating assets for testnets. I think we should add a field to our data and then use the same assets for both:

{
  id: "0x13881",
  token: "MATIC",
  label: "Mumbai", // This is what we use atm
  rpcUrl: "https://matic-mainnet.chainstacklabs.com",
  blockExplorerUrl: "https://mumbai.polygonscan.com/",
  icon: "Polygon" // If we add this new field, we'll just use the same icon -unless we want different ones, of course
}
github-actions[bot] commented 1 year ago

Please test this PR on: https://v2-staging-284-dot-fuji-306908.ey.r.appspot.com

brozorec commented 1 year ago

Sure, let's reuse assets, especially if it's for testnets

ferostabio commented 1 year ago

@brozorec got it. And what about the networks, can we remove any?

brozorec commented 1 year ago

@brozorec got it. And what about the networks, can we remove any?

Yeah, I don't even know wtf is Potcoin lol

Fantom is not supported by Connext yet but let's keep it, I think they will add it at some point.