search

Fujicracy / fuji-v2

Cross-chain money market aggregator
https://fuji-v2-frontend.vercel.app
15 stars 10 forks source link

Positions summary page functional #290

Closed 0xdcota closed 1 year ago

github-actions[bot] commented 1 year ago

Please test this PR on: https://v2-staging-290-dot-fuji-306908.ey.r.appspot.com

brozorec commented 1 year ago

@DaigaroCota great job, so far :+1: I haven't dived into the code but here some preliminary observations:

  1. display chain of the position; refer to designs (use the pattern from here)

  2. display a loader while loading positions similar to the markets page

  3. user is on the page but w/o a connected wallet, we need to display a button "Connect Wallet"

  4. when the user doesn't have any position, we need to display a placeholder "You don't have open positions yet" and a button "Borrow"

If 3. and 4. are not in the designs, we have to check with Mark and create a "Design" ticket for it.

0xdcota commented 1 year ago

@DaigaroCota great job, so far 👍 I haven't dived into the code but here some preliminary observations:

  1. display chain of the position; refer to designs (use the pattern from here)
  2. display a loader while loading positions similar to the markets page
  3. user is on the page but w/o a connected wallet, we need to display a button "Connect Wallet"
  4. when the user doesn't have any position, we need to display a placeholder "You don't have open positions yet" and a button "Borrow"

If 3. and 4. are not in the designs, we have to check with Mark and create a "Design" ticket for it.

working on 3. Though I think I would need some guidance. Cases to address are: 1 If no wallet connected show positions tables with message: Please connect wallet. 2 if connected show loader, until positions load. 3 When loaded if positions array has no positions show: No open positions. 4 if loaded and has positions show position rows. 5 If change of wallet go back to line 2.

0xdcota commented 1 year ago

@DaigaroCota great job, so far 👍 I haven't dived into the code but here some preliminary observations:

  1. display chain of the position; refer to designs (use the pattern from here)
  2. display a loader while loading positions similar to the markets page
  3. user is on the page but w/o a connected wallet, we need to display a button "Connect Wallet"
  4. when the user doesn't have any position, we need to display a placeholder "You don't have open positions yet" and a button "Borrow"

If 3. and 4. are not in the designs, we have to check with Mark and create a "Design" ticket for it.

working on 3. Though I think I would need some guidance. Cases to address are: 1 If no wallet connected show positions tables with message: Please connect wallet. 2 if connected show loader, until positions load. 3 When loaded if positions array has no positions show: No open positions. 4 if loaded and has positions show position rows. 5 If change of wallet go back to line 2.

All suggestions here have been implemented. @brozorec this should be ready for review and merge. Thanks @ferostar for the help and contributions.

brozorec commented 1 year ago

close #289

brozorec commented 1 year ago

pushed some changes and approved, if it's ok for you, we can merge to main @DaigaroCota @ferostar