Morpho lending provider (fix) - Githubissues

Fujicracy / fuji-v2

Cross-chain money market aggregator

https://fuji-v2-frontend.vercel.app

15 stars 10 forks source link

Morpho lending provider (fix) #298

Closed pedrovalido closed 1 year ago

pedrovalido commented 1 year ago

As suggested by the morpho team on the PR:

[x] change blocks per year
[x] use totalBalance instead of suppliedOnPool + suppliedP2P
[x] change _getAddrmapper to _getAddrMapper

Regarding the other suggestions:

Different order of returned outputs on ILensInterface for both MorphoAave and MorphoCompound has no impact on the code as they're not being used (changing it would require "unmerging" both interfaces and is not needed as of now)
Precise assertion instead of GT or LT is going to be changed in the future but we have a slight problem with inaccuracies as of now