Fujicracy / fuji-v2

Cross-chain money market aggregator
https://fuji-v2-frontend.vercel.app
15 stars 10 forks source link

Safety notice and onboarding added #355

Closed NikolaiYurchenko closed 1 year ago

NikolaiYurchenko commented 1 year ago

ticket: https://github.com/Fujicracy/fuji-v2/issues/331

PR Notes

ferostabio commented 1 year ago

@NikolaiYurchenko great job, thanks for the work.

Can you make a couple of really small changes?

ferostabio commented 1 year ago

@brozorec everything looks good, but workflow fails because "by default, secrets are not passed to workflows triggered from forks". Want to have a look because merging?

brozorec commented 1 year ago

I suggest the following improvements before merging to "main":

NikolaiYurchenko commented 1 year ago

I suggest the following improvements before merging to "main":

  • make the mouse cursor a pointer over "Skip, I'll explore ..."
  • make the points clickable with the mouse cursor as a pointer and navigate between steps image
  • the button "Next" becomes "Finish" at the last step
  • the height of the onboarding modal stays fixed throughout the three steps

Sure, will do