Closed NikolaiYurchenko closed 1 year ago
@NikolaiYurchenko great job, thanks for the work.
Can you make a couple of really small changes?
/components/Shared
to /components/Onboarding
, don’t want to make Shared
too big and the components won't be actually used by others.isTermsAccepted
to hasAcceptedTerms
isPreviouslyAccepted
@brozorec everything looks good, but workflow fails because "by default, secrets are not passed to workflows triggered from forks". Want to have a look because merging?
I suggest the following improvements before merging to "main":
I suggest the following improvements before merging to "main":
- make the mouse cursor a pointer over "Skip, I'll explore ..."
- make the points clickable with the mouse cursor as a pointer and navigate between steps
- the button "Next" becomes "Finish" at the last step
- the height of the onboarding modal stays fixed throughout the three steps
Sure, will do
ticket: https://github.com/Fujicracy/fuji-v2/issues/331
PR Notes