Signature tooltip

[NikolaiYurchenko]

https://github.com/Fujicracy/fuji-v2/issues/370

[ferostabio]

@NikolaiYurchenko I tried to borrow and the tooltip didn't show up and realized you made a mistake.

You shouldn't use the needsAllowance function, that's not what we're trying to know. Use borrow.store's needsSignature property instead. They're two completely separate things.

• To know if a particular operation needs the user's signature/permit we callSdk.needSignature(route.actions))
• To know if the we need to show the allowance modal we use sdk.getAllowanceFor(token, Address.from(address))

Actually you'll have to simplify the code. Remove needsAllowance function and replace with the needsSignaure prop.

[NikolaiYurchenko]

that was my first sollution but seems like we additionally call sdk on every input change because we arent doing this now i believe. I'll work on this more

[ferostabio]

that was my first sollution but seems like we additionally call sdk on every input change because we arent doing this now i believe. I'll work on this more

Yes, we are because in order to know the operation type we need to check the user's input in real-time. Let me give you an example:

• The user enters the screen to manage a position. By default, it's DEPOSIT_AND_BORROW.
• He enters a 1 in debt, which means we change to BORROW
• He enters 0.1 in collateral, which means we're back to DEPOSIT_AND_BORROW.
• The user changes a chain.
• Now he deletes the debt, so it's just a DEPOSIT
• Now he changes to Remove position

All of the above change the operation type and so we make a lot of calls to know if the user needs to sign the thing or not. Now, if we're still making too many calls and we can improve, great.