Big LTV warning modal - Githubissues

Fujicracy / fuji-v2

Cross-chain money market aggregator

https://fuji-v2-frontend.vercel.app

15 stars 10 forks source link

Big LTV warning modal #382

Closed NikolaiYurchenko closed 1 year ago

NikolaiYurchenko commented 1 year ago

https://github.com/orgs/Fujicracy/projects/2/views/1?pane=issue&itemId=22671819

UPD: added 2 digits after period fixation of LTV

ferostabio commented 1 year ago

@NikolaiYurchenko haven't tested, but just from a UI perspective, please add a couple of small changes:

Change the amount to so it has no decimals, just 74%.
Increase the font size
Change it so there are two different paragraphs. Start the second one with "Please..."

NikolaiYurchenko commented 1 year ago

@ferostar Thanks for the review, will do!

ferostabio commented 1 year ago

@NikolaiYurchenko I'm afraid we have another issue. If the operation needs to be signed, we proceed with the action instead of showing the ltv modal:

Captura de pantalla 2023-03-16 a la(s) 20 32 41

Please make sure that all of the button actions use it (save for when we want to change a chain, connect the wallet, etc., actions that clearly have precedence because they mean the operation can't be made at all).

NikolaiYurchenko commented 1 year ago

@ferostar in you previous comment your LTV is 58% and modal shouldn't be shown. Can you please try in one more time because I can not reproduce

ferostabio commented 1 year ago

@ferostar in you previous comment your LTV is 58% and modal shouldn't be shown. Can you please try in one more time because I can not reproduce

Completely right, my bad -I was looking at the recommended ltv instead of the max.