Fujicracy / fuji-v2

Cross-chain money market aggregator
https://fuji-v2-frontend.vercel.app
15 stars 10 forks source link

Fix errors in console #386

Closed brozorec closed 1 year ago

brozorec commented 1 year ago

Context

There are some errors thrown in the console that don't bother the UI but make it difficult to debug. They are next.js related or MUI related.

Some examples: image image

TODOs

NikolaiYurchenko commented 1 year ago

2 of them were fixed here and here

waiting to be reviewed and merged

NikolaiYurchenko commented 1 year ago

working on third

stuck but found this https://github.com/facebook/react/issues/24508

ferostabio commented 1 year ago

@NikolaiYurchenko we discussed this privately, forgot to add it here. Did you find anything about [zustand devtools middleware] Please install/enable Redux devtools extension? I get that warning printed into the console even if I already installed the Chrome extension.

NikolaiYurchenko commented 1 year ago

@ferostar this should be only for dev environment since

if (__DEV__ && typeof window !== 'undefined') { 

But I`ll search more just to make sure

ferostabio commented 1 year ago

@ferostar this should be only for dev environment since

if (__DEV__ && typeof window !== 'undefined') { 

But I`ll search more just to make sure

Yes, this will never happen on production, it's mostly a convenience for us developers 😅. We always get one of those for each store, so the console gets cluttered. No sense spending much time on this, but please have a look!

ferostabio commented 1 year ago

Simple issues were addressed, and we now know that Warning: The result of getSnapshot should be cached to avoid an infinite loop is caused by react.