Chain and constants refactor

ferostabio commented 1 year ago

Implements issue https://github.com/Fujicracy/fuji-v2/issues/392.

@brozorec please have a look.

The chain implementation was pretty confusing. Sometimes our own Chain class was passed around, but others web3-onboards. This means we passed around chain ids as our own ChainId, as numbers and as hex string values in a way not very consistent. Now we only use our chains, meaning we mostly pass around ChainId and only convert to hex when we need to interact with the onboard library.
In order to implement the above, I created a new chain-properties.ts constants file and convenience properties to the Chain class.
I also added the DEFAULT_SLIPPAGE constant and a couple of URLs to a new commons

github-actions[bot] commented 1 year ago

Please test this PR on: https://v2-staging-393-dot-fuji-306908.ey.r.appspot.com

ferostabio commented 1 year ago

@brozorec I'm not sure about the CONNEXT_URL function since, well, it's not a constant 😅, but the code is much cleaner this way. Should we move it somewhere else?

ferostabio commented 1 year ago

Thank you for the feedback! On it

Fujicracy / fuji-v2

Chain and constants refactor #393