Fujicracy / fuji-v2

Cross-chain money market aggregator
https://fuji-v2-frontend.vercel.app
15 stars 10 forks source link

Mobile frontend #396

Closed ferostabio closed 1 year ago

ferostabio commented 1 year ago

Implementation of issue https://github.com/Fujicracy/fuji-v2/issues/394

WIP

github-actions[bot] commented 1 year ago

Please test this PR on: https://v2-staging-396-dot-fuji-306908.ey.r.appspot.com

ferostabio commented 1 year ago

Two quick things I noticed on the overview dialog @NikolaiYurchenko :

ferostabio commented 1 year ago

Added a final tweak and it looks good, want to have a peek before merging @brozorec ?

ferostabio commented 1 year ago

I assigned this one to my self so I can't review it 😅

brozorec commented 1 year ago

My feedback:

ferostabio commented 1 year ago

menu: Wallet is stuck to address. What about Transaction history, do we have any designs for it?

We don't have anything. When the user taps either Wallet or Transaction history, we just hide the modal. I would remove the transaction history for the time being.

ferostabio commented 1 year ago

All fixed, can't reproduce the Metamask one -probably because I tested with a wallet with no positions. Shouldn't have anything to do. Still, adding Sentry will help.

Instead of adding a new modal for the account, I simply added the one we already have. Meaning, we now have the transaction list 🥳.

Give it a try @brozorec !