Warning block on existing position

[NikolaiYurchenko]

Warning block on Borrow page to show in same open position exists

[github-actions[bot]]

Please test this PR on: https://v2-staging-429-dot-fuji-306908.ey.r.appspot.com

[ferostabio]

• [x] Remove the failureForMode check since the idea is to always trigger the meta update (as long as there's an active vault, we simply don't want to check anymore and this means passing 0 if input: '')
• [x] Make sure we trigger an update to the meta as soon as we have an active vault (we already do when changing it)
• [ ] Make sure passing 0 to the preview calls works for all 'modes'
• [x] Prevent showing the warning sign if we don't have route information (sing it might be mistaken and we'll only know when having it)
• [x] Update the warning text: it's not just a matter of changing a chain but changing to a different route, as mentioned above

Made the PR into a draft again since there's still a lot to do.

[ferostabio]

@NikolaiYurchenko turned the PR into a draft again and added a checklist.

[ferostabio]

@brozorec when calling preview calls in a cross-chain operation and we pass 0 in both amount fields, we get the following error from the sdk:

Sdk error while attempting to set meta: division-by-zero [ See: https://links.ethers.org/v5-errors-NUMERIC_FAULT-division-by-zero ] (fault="division-by-zero", operation="div", code=NUMERIC_FAULT, version=bignumber/5.7.0)

[ferostabio]

• [x] @NikolaiYurchenko there was a leftover UI task, routing card icons aren't centered, pls fix fix it here (and make sure to improve the code while doing it, there's a lot of code duplication in that component when rendering the steps)

[brozorec]

@ferostar @NikolaiYurchenko great job on this and the following PR :muscle:

I have these suggestions to improve the warning messages and the routing modal:

Messages

• [x] 1. when there's a single route

"Based on your selection, we've noticed that you have an open WETH/USDC position on (icon) Optimism. You may proceed to manage it."

• Replace WETH, USDC and Optimisim with the corresponding values.

• [x] 2. when there's more than one route

"Based on your selection, we've noticed that you have an open WETH/USDC position on (icon) Optimism. You may proceed to manage it.

If you're trying to open a similar position on another chain, please [select a different route]."

• Replace WETH, USDC and Optimisim with the corresponding values.
• The last sentence is on a new line.
• [select a different route] is underlined and clickable and opens the routing modal.

Routing modal

• [x] Regarding the routing modal, displaying zeros may be confusing, so I suggest hiding them:

• [x] when routes are empty We may display the following:

  1. WETH from Optimism
  2. Bridge to Gnosis via Connext
  3. Deposit WETH
  4. Borrow USDC
  5. Get USDC on Gnosis

• [ ] when routes are populated We may display the following:

  1. 0.13 WETH from Optimism
  2. Bridge to Gnosis via Connext
  3. Deposit 0.13 WETH
  4. Borrow 12 USDC
  5. Get 12 USDC on Gnosis

[ferostabio]

Another important issue @brozorec is that we just don't show the routing modal on a mobile device.

[ferostabio]

Turned the comments above into checklists so it's clear what remains to be done

[NikolaiYurchenko]

Message changed, on mobile underline is hidded, returned input check becase Mark told me to do it

[ferostabio]

Have a look @brozorec !

[brozorec]

I removed the chain icon because it didn't look good (sorry about that). I also used the vault values because a position is determined by the vault where it was open, not by the start and the end step. The steps define only the route.