Fujicracy / fuji-v2

Cross-chain money market aggregator
https://fuji-v2-frontend.vercel.app
15 stars 10 forks source link

APY chart #441

Closed NikolaiYurchenko closed 11 months ago

NikolaiYurchenko commented 1 year ago

https://github.com/Fujicracy/fuji-v2/issues/443 Preparation for a Analytics Tab feature;

github-actions[bot] commented 1 year ago

Please test this PR on: https://v2-staging-441-dot-fuji-306908.ey.r.appspot.com

ferostabio commented 1 year ago

Hi @NikolaiYurchenko! Can you tell me what is this issue about?

NikolaiYurchenko commented 1 year ago

@ferostar Hi, it is a draft for future PR for Analytics tab in Overview

ferostabio commented 1 year ago

Great work so far @NikolaiYurchenko !

I honestly didn't know about nivo, looks pretty cool.

Two quick things I noticed.

ferostabio commented 1 year ago

@NikolaiYurchenko love how it's looking!

A couple of small things:

ferostabio commented 1 year ago

@NikolaiYurchenko I left a similar comment in the UI issues PR. We need to standardize tooltips. Sometimes we change pointer, sometimes we don't. I don't think we should change it unless the user can tap -so please change all the tooltips not to change the pointer.

NikolaiYurchenko commented 1 year ago

for some reason cant commit merge rn, getting sol files errors ◼ yarn format:fix /Users/chau/Projects/fuji-v2/packages/protocol/script/02_SignBorrow.s.sol

ferostabio commented 11 months ago

Three pending tasks were done. Should now be a matter of tweaking, fixing and polishing.

brozorec commented 11 months ago

Pushed some changes to remove the filtering the null values and here's some UI feedback:

  1. Polygon, WETH/DAI image
  1. Arbitrum, WETH/USDC image
  1. Optimism, WETH/USDC image