Closed NikolaiYurchenko closed 11 months ago
Please test this PR on: https://v2-staging-441-dot-fuji-306908.ey.r.appspot.com
Hi @NikolaiYurchenko! Can you tell me what is this issue about?
@ferostar Hi, it is a draft for future PR for Analytics tab in Overview
Great work so far @NikolaiYurchenko !
I honestly didn't know about nivo
, looks pretty cool.
Two quick things I noticed.
tooltip
to not expect any
as param?@NikolaiYurchenko love how it's looking!
A couple of small things:
../components/Shared/Chart/ApyChart.tsx
any
as param)@NikolaiYurchenko I left a similar comment in the UI issues PR. We need to standardize tooltips. Sometimes we change pointer, sometimes we don't. I don't think we should change it unless the user can tap -so please change all the tooltips not to change the pointer.
for some reason cant commit merge rn, getting sol files errors ◼ yarn format:fix /Users/chau/Projects/fuji-v2/packages/protocol/script/02_SignBorrow.s.sol
Three pending tasks were done. Should now be a matter of tweaking, fixing and polishing.
Pushed some changes to remove the filtering the null values and here's some UI feedback:
https://github.com/Fujicracy/fuji-v2/issues/443 Preparation for a Analytics Tab feature;