Fujicracy / fuji-v2

Cross-chain money market aggregator
https://fuji-v2-frontend.vercel.app
15 stars 10 forks source link

Vault rounding and complementary debt functions #487

Closed 0xdcota closed 1 year ago

0xdcota commented 1 year ago

This pull request addresses multiple vulnerabilities and issues reported in the Macro report audit.

M-2 Vault rounding inconsistencies L-6 Lack of option of fully payback loan Q-2 Unnecessary use of _msgSender() Q-3 Double conversion of assets<>shares in withdraw function flow G-1 and G2 Immutable definition of vault asset and debtAsset

0xdcota commented 1 year ago

@pedrovalido updated all the missing docs in TODOs. This should be ready to be merged.

pedrovalido commented 1 year ago

Great! Let's merge then