Closed ferostabio closed 1 year ago
Please test this PR on: https://v2-staging-513-dot-fuji-306908.ey.r.appspot.com
@NikolaiYurchenko we've been doing some cleanup, in order to continue with that, please create a branch with this as base and move all the acceptTermsOfUse
, getOnboardStatus
, setExploreInfoSkipped
and related functions to the auth
helper since they don't make any use of the store
.
@NikolaiYurchenko we've been doing some cleanup, in order to continue with that, please create a branch with this as base and move all the
acceptTermsOfUse
,getOnboardStatus
,setExploreInfoSkipped
and related functions to theauth
helper since they don't make any use of thestore
.
@NikolaiYurchenko pls implement the above in using the login improvement branch as base, otherwise it will a big pita.
Some feedback:
While debugging, I came across the logic of how we set when the user has a balance in the active vault. With the new returned type VaultsWithFinancails
, we have this data so there's no need to fetch it separately. @ferostabio can you have a look, do I miss anything there?
close #173 close #174