Fujicracy / fuji-v2

Cross-chain money market aggregator
https://fuji-v2-frontend.vercel.app
15 stars 10 forks source link

Borrow: Pending Tx FlyOut #53

Closed iafhurtado closed 1 year ago

iafhurtado commented 1 year ago

Meta

Estimation time : 4 days (3 days integration + 1 day logic)

Transaction processing (normally three transaction in one bundle)

Image

Transaction Pending is still visible in the UI with FlyOver

Image

Transaction successful

Image

Same chain Wait for the transaction to complete.. Once it complete we assume display the modal with steps 1 & 2 already checked (can be one then one second after 2). There is only 2 steps: deposit and borrow

Different chains Get the receipt = await tx.wait(), then filter events and get arg of one of the events. @brozorec please complete this description.

iafhurtado commented 1 year ago

This screen was missing from this ticket to allow the user to open again the Tx Pending Flyout, if they click in their wallet component in the top right, they will be able to see their recent transactions history and even open the Tx Pending Fylout

Image

doliG commented 1 year ago
doliG commented 1 year ago

Hey @brozorec ,

We discussed this ticket during daily and you tell me that I'll be able to find in the sdk what I need. I checked the definition of Sdk and BorrowingVault class, but I can't find any useful method to track the progress of a transaction.

Can you help ?

What I need:

I'm available to have a call about it. In the meantime I put this ticket in blocked and start #135 .

brozorec commented 1 year ago

hey @doliG part of what you need could be found in steps returned from const { steps, actions, bridgeFee, estimateTime } = await sdk.previewDepositAndBorrow(vault, amount1, amount2, token1, token2, user); https://github.com/Fujicracy/fuji-v2/tree/main/packages/sdk#transation

As we said during the daily, for same-chain transactions, all steps execute in the same moment, so nothing to track there.

Regarding the cross-chain txns, let me sleep over it, and tomorrow we can devise a solution ;) obviously, we have to make them functional first.

doliG commented 1 year ago

@brozorec in that case, does it make sense to show it when borrowing on the same chain ? I mean if all the steps are done at once... 🤔

brozorec commented 1 year ago

@brozorec in that case, does it make sense to show it when borrowing on the same chain ? I mean if all the steps are done at once... thinking

Why not? It's still a nice UX to display the steps a tx is going through (in the case of same-chain tx, there are only two). If you like, you can put 2-3 sec timeout between those so that it feels more interactive.

doliG commented 1 year ago

Make sense, I'll do it

doliG commented 1 year ago

@brozorec I've done all I can on this, but without the return we talk yesterday by the SDK I can't go any further. I put this ticket in blocked, and start #135 in the meantime. You can test what I've done so far on staging (see PR #149 )

brozorec commented 1 year ago

@doliG you can check here https://testnet.amarok.connextscan.io/transfers if Connext processes well the cross-chain calls

doliG commented 1 year ago

gotcha