The hardcoded slippage check included in the encoded arguments in the xReceive(...) function of the contract ConnextRouter.sol L146 and further checked in L243:
creates a problem when user updates slippage at the Connext.sol contract (outside the scope of Fuji).
Meaning that there is a difference of slippage acceptance between Fuji and Connext.
From a user experience the slippage change should be atomic and updated simultaneaously both in Connext and Fuji.
Therefore, after internal consideration we believe Fuji's slippage check is redundant and must be removed.
Additionally this resolution solves additional problems reported by the Macro audit in issues M-7 #454 and M-8 #455.
The hardcoded slippage check included in the encoded arguments in the
xReceive(...)
function of the contract ConnextRouter.sol L146 and further checked in L243:creates a problem when user updates slippage at the Connext.sol contract (outside the scope of Fuji). Meaning that there is a difference of slippage acceptance between Fuji and Connext. From a user experience the slippage change should be atomic and updated simultaneaously both in Connext and Fuji.
Therefore, after internal consideration we believe Fuji's slippage check is redundant and must be removed.
Additionally this resolution solves additional problems reported by the Macro audit in issues M-7 #454 and M-8 #455.