Closed ferostabio closed 11 months ago
It’s a very, very early draft, a starting point, but wanted to push as soon as possible so, with a couple of tweaks if needed, @NikolaiYurchenko can already start working
borow.store
's debt
property is now undefined
by default and quickly updated all usages. UI mostly just checks for undefined and returns either null
or <>
.debt
value is more than enough.TODO
in places we need to think aboutPosition
object is a good example. In the positions
helper's viewDynamic…
function, it expects a debt
object. And the user won't be managing a position and have no debt, so there's no point in allowing there an optional field. Nothing big, but need to figure it out.Please test this PR on: https://v2-staging-537-dot-fuji-306908.ey.r.appspot.com
https://github.com/Fujicracy/fuji-v2/assets/501915/2633548a-29ef-4772-9c15-bd2d627b97fb
MUI: You have provided an out-of-range value for the select component.
Warning: Cannot update a component (
BorrowHeader) while rendering a different component (
BorrowPage). To locate the bad setState() call inside
BorrowPage, follow the stack trace as described in https://reactjs.org/link/setstate-in-render
[x] When switching tokens or networks, the list of "All Vaults" can get updated. Add a skeleton loader so that the change is more evident.
[x] "See all vaults" is with a smaller font size, rename "Close" to "Hide".
[x] Add animation when folding and unfolding.
[x] UI issue
[x] When I directly hit "/my-positions/VAULT_ADDR-CHAIN_ID", the page doesn't load.
[x] When I'm on manage position, I can't do a deposit-only or a withdraw-only.
[x] I want to make a payback+withdraw and there's an approval. After the approval tx gets executed, no signature gets prompted. There's an error notification and the button doesn't stop loading.
[x] I want to withdraw only. Approval shouldn't be needed:
After I approve (although I shouldn't be asked for), the button displays "Signs & Borrow", I guess there's an issue with the mode
:
I'm on the borrow page and the current chain is different than the collateral chain. When I change the chain, the form re-init.
I either cannot reproduce or don't fully understand this one @brozorec
close #573