Lending markup (old)

[vercel[bot]]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
fuji-v2-frontend	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 23, 2023 11:05am

[ferostabio]

Some important points to tackle once that the branch is up to date @NikolaiYurchenko .

• The SDK changed, there’s no LendingProviderDetails anymore so the rearrangeWith… function needs to be refactored (ps: I moved the function to a new lending helper, we shouldn’t add lending functions to any borrowing related code).
• viewDynamicPosition and showPosition changed, params are different and can now be undefined, so the flow needs to be updated and double checked.
• Reintroduce the commented out components, all of them changed this month, so please update them accordingly.
• Remove duplicated code, and create reusable components whenever possible. Rows and tables are currently sharing a lot of functionality and most code has just been duplicated (loaderOrError is a small but good example).
• Get rid of all any, please use types whenever possible
• Rename components like BorrowBox if they’re going to be used in Lending. This type of component won’t use borrow.store but a new lending.store. It’s not just a matter of doing the markup, we have to be thorough in the component structure. It makes sense to create a dumber FormBox component, for instance, that accepts data that will be sent from BorrowBox and LendingBox (each connected to its related store).

[brozorec]

moved all related frontend work to #631