ferostabio
commented
11 months ago note: there will be new bugs related to borrow/position page. too many cross state changes happening like isEditing or willLoadBorrow. they are unnessesary and buggy so will be making problems in future. Suggestion for future refactoring: do not mix logic to reuse code but create separate pages for borrow and manage-position so we will get rid of unnessesary pain checking where we are, should we update smth and component visible unmounting
Fully agree. As we were discussing privately, both borrow.store properties should be temporary solutions. Having both pages using the same store was a better idea when both screens fully matched. The more differences we add, the more hard it will be to maintain and more errors are likely to appear. We should eventually revisit the structure.
note: there will be new bugs related to borrow/position page. too many cross state changes happening like isEditing or willLoadBorrow. they are unnessesary and buggy so will be making problems in future. Suggestion for future refactoring: do not mix logic to reuse code but create separate pages for borrow and manage-position so we will get rid of unnessesary pain checking where we are, should we update smth and component visible unmounting