search

Fujicracy / fuji-v2

Cross-chain money market aggregator
https://fuji-v2-frontend.vercel.app
15 stars 10 forks source link

Baserouter token check logic and flashloans #622

Closed 0xdcota closed 10 months ago

0xdcota commented 11 months ago

This pull request addresses Item #-5 and #-33 of the Three Sigma security audit.

vercel[bot] commented 11 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **fuji-v2-frontend** | ⬜️ Ignored ([Inspect](https://vercel.com/fuji-finance/fuji-v2-frontend/GrsLqzgSFpj4nzTctUXcu1djHtwe)) | [Visit Preview](https://fuji-v2-frontend-git-protocol-fix3sigma-5-3-ca912d-fuji-finance.vercel.app) | | Jul 4, 2023 4:21am |
0xdcota commented 11 months ago

After working in the previous items it was logic to address also Item #-11. Regarding optimization of _tempToCheck unnecesary state variable.

0xdcota commented 11 months ago

After working in the previous items it was logic to address also Item #-19. Regarding reentrancy concerns.

0xdcota commented 11 months ago

After working in the previous items it was logic to address also Item #-2. Regarding tokensToCheck returned value in memory.

0xdcota commented 11 months ago

After working in the previous items it was logic to address also Item #-3. Regarding token-shares check in the token balances checks of the router.

0xdcota commented 10 months ago

@pedrovalido I resolved conflicts on this pull request, now free for your review.

pedrovalido commented 10 months ago

Awesome work guys !!